Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SequenceMatcherapproach.Description
sequence(existingdifflib.SequenceMatcher),levenshtein(normalized edit-distance),compression(NCD-inspired compression approximation for Kolmogorov-complexity-style similarity), andvector(cosine similarity over character n-gram count vectors), with a dispatcher (get_similarity).--algorithms(comma-separated list orall) and--combine-mode(unionorintersection) to control which algorithms are used and whether to include pairs matched by any algorithm or only those common to all selected algorithms.should_compare_pair, individual similarity functions, andfind_similar_name_pairs) to support multi-algorithm evaluation and aggregation.Testing
python3 tools/threat_actor_similarity_report.py --helpand confirmed the new options are shown and exit succeeded.--algorithms sequence,levenshtein,vector --combine-mode union --threshold 0.5which completed successfully and produced markdown/JSON output reportingAnalyzed normalized names: 5andPotential similar name pairs: 3.--algorithms sequence --max-results 5in this environment which timed out due to pairwise processing cost on the full dataset (environment timeout), indicating longer runs may be needed for large clusters.Codex Task